feat: Use execa #115
Draft
feat: Use execa #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wikiwix
reviewed
Nov 11, 2024
| @@ -29,7 +26,7 @@ function _execute(cwd: string, subcommand: string, options: string[] = []) { | |||
|
|
|||
There was a problem hiding this comment.
As far as I can see, for the array in QUOTE_PATH to help with escaping you would need to use execa's array syntax (which is the concept I was referring to in the issue)
There was a problem hiding this comment.
Oh right. I did a standalone test using array and nesting it.
But forgot to do it here, I guess on line 28 for command as array rather than strings.
There was a problem hiding this comment.
Yes, (besides git needing to be extra). Line 29 could look like this as far as I see it:
return execa("git", [...QUOTE_PATH, subcommand, ...options] ,{ cwd });There was a problem hiding this comment.
thanks. I added #116 as a task to update to module type and then this PR will be possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #114
The new approach seems to be okay except for errors in running - it complains about the modules.
Switching package.json to type module and tsconfig to esnext did not help as that caused other issues in the build/compile step.