fix(IB_AirConditionerVariableRefrigerantFlow): improve ToOS (#99)

* fix(IB_AirConditionerVariableRefrigerantFlow): improve ToOS * fix(AirConditionerVariableRefrigerantFlow): throw an exception when failed to add terminals * test(large model): ignore large model test for now * fix(OpenStudio): upgrade to 3.6.1 on Linux * fix(Console): upgrade to 3.6.1 on Linux * test(LargeModel): add test back
MingboPeng · Sep 19, 2023 · 0505d36 · 0505d36
1 parent 1787b31
commit 0505d36
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/src/Ironbug.Console/Ironbug.Console.csproj b/src/Ironbug.Console/Ironbug.Console.csproj
@@ -23,7 +23,7 @@
 
 	<!-- for Linux -->
 	<ItemGroup Condition=" '$([System.Runtime.InteropServices.RuntimeInformation]::IsOSPlatform($([System.Runtime.InteropServices.OSPlatform]::Linux)))' ">
-		<PackageReference Include="NREL.OpenStudio.linux-x64" Version="3.5.1" />
+		<PackageReference Include="NREL.OpenStudio.linux-x64" Version="3.6.1" />
 	</ItemGroup>
 
 	<!-- <Target Name="PostBuild" AfterTargets="PostBuildEvent">

diff --git a/src/Ironbug.HVAC/Ironbug.HVAC.csproj b/src/Ironbug.HVAC/Ironbug.HVAC.csproj
@@ -23,7 +23,7 @@
 
 	<!-- for Linux -->
 	<ItemGroup Condition=" '$([System.Runtime.InteropServices.RuntimeInformation]::IsOSPlatform($([System.Runtime.InteropServices.OSPlatform]::Linux)))' ">
-		<PackageReference Include="NREL.OpenStudio.linux-x64" Version="3.5.1" IncludeAssets="compile;build" />
+		<PackageReference Include="NREL.OpenStudio.linux-x64" Version="3.6.1" IncludeAssets="compile;build" />
 	</ItemGroup>
 
 	<ItemGroup>

diff --git a/src/Ironbug.HVAC/Loops/IB_AirConditionerVariableRefrigerantFlow.cs b/src/Ironbug.HVAC/Loops/IB_AirConditionerVariableRefrigerantFlow.cs
@@ -42,17 +42,18 @@ public override IB_ModelObject Duplicate()
         }
         public override HVACComponent ToOS(Model model)
         {
-            var existObj = model.getAirConditionerVariableRefrigerantFlows().FirstOrDefault(_ => _.comment() == this.GetTrackingID());
+            var existObj = this.GetIfInModel<AirConditionerVariableRefrigerantFlow>(model, this.GetTrackingID());
             if (existObj != null) return existObj;
 
             var newObj = base.OnNewOpsObj(NewDefaultOpsObj, model);
 
             var allTerms = this.Terminals;
             foreach (var terminal in allTerms)
             {
-
-                var item = (IB_ZoneHVACTerminalUnitVariableRefrigerantFlow)terminal;
-                newObj.addTerminal((ZoneHVACTerminalUnitVariableRefrigerantFlow)item.ToOS(model));
+                var t = terminal.ToOS(model) as ZoneHVACTerminalUnitVariableRefrigerantFlow;
+                var done = newObj.addTerminal(t);
+                if (!done)
+                    throw new ArgumentException("Failed to add ZoneHVACTerminalUnitVariableRefrigerantFlow");
 
             }