fix(4PipeFanCoil): support electic heating coil

MingboPeng · Oct 6, 2022 · 7dd003a · 7dd003a
1 parent 4591097
commit 7dd003a
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 4 deletions.
diff --git a/....Grasshopper/Component/Ironbug/ZoneEquipments/ZoneHVAC/Ironbug_ZoneHVACFourPipeFanCoil.cs b/....Grasshopper/Component/Ironbug/ZoneEquipments/ZoneHVAC/Ironbug_ZoneHVACFourPipeFanCoil.cs
@@ -20,7 +20,7 @@ public Ironbug_ZoneHVACFourPipeFanCoil()
 
         protected override void RegisterInputParams(GH_InputParamManager pManager)
         {
-            pManager.AddGenericParameter("HeatingCoil", "coilH_", "Heating coil to provide heating source. Must be CoilHeatingWater.", GH_ParamAccess.item);
+            pManager.AddGenericParameter("HeatingCoil", "coilH_", "Heating coil to provide heating source. Can be CoilHeatingWater or CoilHeatingElectric.", GH_ParamAccess.item);
             pManager[0].Optional = true;
             pManager.AddGenericParameter("CoolingCoil", "coilC_", "Cooling coil to provide cooling source. Must be CoilHeatingWater.", GH_ParamAccess.item);
             pManager[1].Optional = true;
@@ -39,7 +39,7 @@ protected override void SolveInstance(IGH_DataAccess DA)
 
 
             var fan = (IB_Fan)null;
-            var coilH = (IB_CoilHeatingWater)null;
+            var coilH = (IB_CoilHeatingBasic)null;
             var coilC = (IB_CoilCoolingWater)null;
 
             if (DA.GetData(0, ref coilH))

diff --git a/src/Ironbug.HVAC/ZoneEquipments/ZoneHVAC/IB_ZoneHVACFourPipeFanCoil.cs b/src/Ironbug.HVAC/ZoneEquipments/ZoneHVAC/IB_ZoneHVACFourPipeFanCoil.cs
@@ -12,7 +12,7 @@ private static ZoneHVACFourPipeFanCoil NewDefaultOpsObj(Model model)
             => new ZoneHVACFourPipeFanCoil(model, model.alwaysOnDiscreteSchedule(), new FanConstantVolume(model), new CoilCoolingWater(model), new CoilHeatingWater(model));
 
         private IB_CoilCoolingWater CoolingCoil => this.GetChild<IB_CoilCoolingWater>();
-        private IB_CoilHeatingWater HeatingCoil => this.GetChild<IB_CoilHeatingWater>();
+        private IB_CoilHeatingBasic HeatingCoil => this.GetChild<IB_CoilHeatingBasic>();
         private IB_Fan Fan => this.GetChild<IB_Fan>();
 
         public IB_ZoneHVACFourPipeFanCoil() : base(NewDefaultOpsObj(new Model()))
@@ -27,7 +27,7 @@ public void SetFan(IB_Fan Fan)
             this.SetChild(Fan);
         }
 
-        public void SetHeatingCoil(IB_CoilHeatingWater Coil)
+        public void SetHeatingCoil(IB_CoilHeatingBasic Coil)
         {
             this.SetChild(Coil);
         }

diff --git a/src/Ironbug.HVAC_Tests/00_DummyTest.cs b/src/Ironbug.HVAC_Tests/00_DummyTest.cs
@@ -23,6 +23,23 @@ public void DummyTest_OS_Coil_Heating_WaterFields()
             Assert.True(true);
         }
 
+        [Test]
+        public void DummyTest_FourPipeFanCoil()
+        {
+            var model = new OpenStudio.Model();
+            var zone = new ThermalZone(model);
+
+            var elecC = new CoilHeatingElectric(model);
+            var f = new ZoneHVACFourPipeFanCoil(model, model.alwaysOnDiscreteSchedule(), new FanConstantVolume(model), new CoilCoolingWater(model), elecC);
+            f.addToThermalZone(zone);
+
+            var hc = f.heatingCoil().OSType();
+            Assert.True(hc == "OS:Coil:Heating:Electric");
+            model.Save( System.IO.Path.Combine(System.IO.Path.GetTempPath(), "test.osm"));
+
+
+        }
+
         [Test]
         public void IB_TypeTest()
         {