Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests; update docs #90

Merged
merged 1 commit into from
Feb 7, 2025
+9 −46
Merged

Fix tests; update docs #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,14 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- name: Determine Checkout Ref
if: github.event_name == 'workflow_dispatch' || github.event.name == 'pull_request'
if: github.event_name == 'workflow_dispatch' || github.event_name == 'pull_request'
run: |
if [ -z "${{ github.event.inputs.checkout_ref }}" ]; then
echo "checkout_ref=${{ github.event.ref }}" >> "GITHUB_ENV"
if [[ "${{ github.event_name }}" == "pull_request" ]]; then
echo "checkout ref is ${{ github.event.pull_request.head.ref }} from pull_request"
echo "checkout_ref=${{ github.event.pull_request.head.ref }}" >> "$GITHUB_ENV"
else
echo "checkout_ref=${{ github.event.inputs.checkout_ref }}" >> "GITHUB_ENV"
echo "checkout ref is ${{ github.event.inputs.checkout_ref }} from dispatch"
echo "checkout_ref=${{ github.event.inputs.checkout_ref }}" >> "$GITHUB_ENV"
fi

- name: Checkout Repository
Expand All @@ -47,7 +49,7 @@ jobs:
run: |
versions=$(git diff --name-only origin/main ${{ github.sha }} | grep -oE 'Formula/mkectl@[0-9.]+' | sed 's/Formula\/mkectl@//')
echo "Versions changed: $versions"
echo "versions=$versions" >> "GITHUB_OUTPUT"
echo "versions=$versions" >> "$GITHUB_OUTPUT"

- name: Cache Homebrew Bundler RubyGems
uses: actions/cache@v4
Expand Down
1 change: 0 additions & 1 deletion Formula/mkectl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ class Mkectl < Formula

bottle do
root_url "https://github.com/Mirantis/homebrew-tap/releases/download/mkectl-4.0.0"
rebuild 2
sha256 cellar: :any_skip_relocation, arm64_sonoma: "17c2a09b18945ae5524217db6ee5d93fa2d47d798dd73b3d48b598877b6b0882"
sha256 cellar: :any_skip_relocation, ventura: "930e1dea198a88a333028ab96ca61289cde78704706efb092261f75a2df45df4"
sha256 cellar: :any_skip_relocation, x86_64_linux: "3661af83ca4671e16a449053e57ebf0db407dba86f919aa2ddcc697007f3a8ee"
Expand Down
38 changes: 0 additions & 38 deletions Formula/[email protected]
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions docs/Release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
3. First create a PR updating `.github/development.env` if any dependency versions should be changed for the new release. Note k0sctl is not a dependency even though it is required for mkectl, this is because k0sctl brew formula is unfortunately not versioned. Merge the PR before proceeding so the actions can use the updated versions.
4. Navigate to the [actions tab ](https://github.com/Mirantis/homebrew-tap/actions/workflows/update-homebrew.yml), and manually run the workflow while providing the new version (i.e `4.0.1`) as an input. Note there should be no "v" in this version. This will create a PR with the updated formula.
5. If you updated dependencies in step 3, you may also need to update dependencies in the formula
6. Once satisfied with the changes, add the `bottle` label to the PR. This will trigger the bottle action which will build and publish the bottles. Additionally, it will update the PR with the bottle SHAs and run some tests.
7. Verify the bottles are published and tests have finished. Once the bottles are published, add the `pr-pull` label to the PR. This will run some final tests and merge the PR if successful.
6. Verify the tests have finished. There should be bottles output as artifacts from the tests - these are used in the following step.
7. Add the `pr-pull` label to the PR. This will run some final tests and merge the PR if successful.
Loading