Enable golangci-lint and go unit test github actions

[kke]

• Enables the golangci-lint action
• Updates .golangci.yml
• Fixes all linting errors
• Adds a simple go.mod/go.sum consistency check
• Enables a go unit test workflow
• Fixes all the errors encountered in unit tests

Some of the modified error messages may be overly verbose and repetitive, but I believe there will be more context to work with when a user reports such an error.

There were a couple of linting errors that were security vulnerabilities found by gosec.

Unit tests have not been passing since Dec 2022.

[cranzy]

Gh action looks good.

It seems to be pointing the linting issue already :)

[james-nesbitt]

will the issues reported get fixed? you could always leave the disabled/enabled plugin list as is, which would result in no errors.

[kke]

As the Jenkins workflows aren't working, maybe they should be removed.

Anything that doesn't go green should not be merged.

[kke]

This will probably conflict @squizzi 's MSR3 PR quite bad.

[kke]

Or squizzis PR makes this conflict but not as bad as I thought :)

[james-nesbitt]

I'll check out how hard this is to rebase now.

[james-nesbitt]

the only real conflict I see (besides the MSR3 rework) is the recent uninstallMCR refactor that @cranzy did. I will ask him to do the rebase.

[kke]

I did the rebase, but there are some failing unit tests. They're not passing on master either. Should not merge anything that doesn't pass.

[cranzy]

There was a logical mistake in the manager.go file, which caused the binary to stop on the first phase that was successful.

[kke]

Just a couple of notes:

• To keep output consistent, use log.Foo("%s: foo foo", h) instead of log.Foo("%s foo foo", h)
• To keep errors consistent, use foo: %w instead of foo => %w.
• The "do not define sentinel errors" that comes from return fmt.Errorf("no bueno") is slightly annoying and perhaps unnecessary as this is not a library. Maybe it could be disabled.

[cranzy]

I've confirmed that both launchpad apply and launchpad reset work as expected locally.