Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanity checking for function imports #802

Merged
merged 5 commits into from
Apr 24, 2017
Merged

Sanity checking for function imports #802

merged 5 commits into from
Apr 24, 2017

Conversation

bcongdon
Copy link
Contributor

Description

  • This PR adds import-checking for user-specified functions. Before uploading, try to import / check that app_function, event functions, and exception_handler functions can be imported and are accessible. Presents an error message if unable to import.
  • Adds test for the above changes

GitHub Issues

#721
#78

@coveralls
Copy link

coveralls commented Apr 22, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 75.754% when pulling ca39b8c on bcongdon:function_checker into c2525a3 on Miserlou:master.

@Miserlou
Copy link
Owner

I like it

@Miserlou Miserlou merged commit d0fe596 into Miserlou:master Apr 24, 2017
@bcongdon bcongdon mentioned this pull request Apr 25, 2017
Closed
@bcongdon bcongdon mentioned this pull request Jun 29, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcongdon @coveralls @Miserlou