Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the German translation and add a directory for the German docu… #1659

Merged
merged 3 commits into from
Jan 18, 2025

Conversation

MrViso
Copy link
Contributor

@MrViso MrViso commented Jan 5, 2025

…mentation of the system with initial translation attempts.

Description.

Motivation and Context.

Screenshots.

Types of Changes.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

…mentation of the system with initial translation attempts.
@snap01
Copy link
Collaborator

snap01 commented Jan 7, 2025

The docs folder is generated from the modules/manual/ folder via the command npm run build-manuals which generates the doc folder and creates the JournalEntry in the system.

You are also able to use the following and the generated files will show the icons / links in the JournalEntry and show as text in the md files.
@Compendium[CoC7.items.3elxAwnv7WCUNwng]{Punch}
[fas fa-user-edit]
[game-icon game-icon-tentacle-strike]

Are you able to create the equivalent files in the modules/manual/ folder?

MrViso and others added 2 commits January 16, 2025 20:58
- Moved German documentation to: /module/manual/de/*
- Added experience.md and wrote some first impressions
- Translated item_archetype.md
- Run 'npm run build-manuals' to generate /docs/de/*
- Pray that everything has now been done correctly
@MrViso
Copy link
Contributor Author

MrViso commented Jan 16, 2025

The docs folder is generated from the modules/manual/ folder via the command npm run build-manuals which generates the doc folder and creates the JournalEntry in the system.

You are also able to use the following and the generated files will show the icons / links in the JournalEntry and show as text in the md files. @Compendium[CoC7.items.3elxAwnv7WCUNwng]{Punch} [fas fa-user-edit] [game-icon game-icon-tentacle-strike]

Are you able to create the equivalent files in the modules/manual/ folder?

Hi, first of all thanks for your feedback. I have tried to take everything you mentioned to heart and hope that I have now implemented everything correctly. I still had to adjust the generate-manuals.js so that it also takes into account the new language files in the /module/manual/de folder. The script then seems to have run correctly from my point of view and has generated the /docs/de folder again and completely.

Does everything fit now?

@snap01 snap01 merged commit fa6de92 into Miskatonic-Investigative-Society:develop Jan 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants