upgrade to 1.2.1: fix fulldomain issue

MohammadRaziei · Oct 10, 2023 · a794080 · a794080
1 parent ad049f6
commit a794080
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/examples/main.cpp b/examples/main.cpp
@@ -54,6 +54,8 @@ int main() {
         "home?o=10&k=helloworld#aboutus");
 
     show(TLD::Host("www.ee.aut.ac.ir").suffix());
+    show(TLD::Host("aut.ac.ir").fulldomain());
+    show(TLD::Host("ee.aut.ac.ir").fulldomain());
 
     show_attr(url, isPslLoaded);
     show(url);

diff --git a/pyproject.toml b/pyproject.toml
@@ -6,7 +6,7 @@ build-backend = "scikit_build_core.build"
 
 [project]
 name = "liburlparser"
-version = "1.2.0"
+version = "1.2.1"
 description="Fastest Url parser in the world"
 readme = "README.md"
 authors = [

diff --git a/src/urlparser.cpp b/src/urlparser.cpp
@@ -196,11 +196,9 @@ const std::string& TLD::Url::domain() const noexcept {
 }
 /// fulldomain
 std::string TLD::Host::Impl::fulldomain() const noexcept {
-    std::string result;
     if (subdomain_.empty())
-        result = domainName();
-    result = subdomain_ + "." + domainName();
-    return result;
+        return domainName();
+    return subdomain_ + "." + domainName();
 }
 std::string TLD::Host::fulldomain() const noexcept {
     return impl->fulldomain();