Fix the "Debug Controller" verb #5204
Open
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LikeLakers2
force-pushed
the
project/debug-verbs/fix-debug-controller
branch
from
68c0c99 to
2e24fe4
Compare
|
Force-pushing to see if I can get the CI to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
The "Debug Controller" verb wasn't doing anything. You'd click on it, and nothing would happen.
Turns out, it was searching for controllers in the wrong place - controllers are considered globals, not part of
/world.This PR fixes that. Now you get this fancy box instead of nothing:
(As an aside - choosing the Global Variables controller causes several seconds of lag, due to the mass amount of data that needs to be rendered. Perhaps a new verb should be added specifically for going through Global Variables?)
Why It's Good For The Game
Enables coders to debug the various controllers with less need for debug printing statements.
Why It's Terrible For The Game
Enables admins with debug permission to abuse the live server even harder.
Changelog
No player-facing changes. This regards a verb that should only be used during debugging (i.e. locally).