Fix a bunch of hard-dels; fix plumbing stuff being qdel'd before initialization; and make unit tests actually output data/unit_tests.json on CI
#5206
+58
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` not being output properly
…things, causing them to be qdel'd before initialization
…d-deling if they were gibbed
LikeLakers2
force-pushed
the
project/hard-dels/fix-alot
branch
from
b43e3d2 to
54db29b
Compare
Kitsunemitsu
added
Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Unit tests were not delaying the round end - this caused a number of issues, from hard-dels not being reported, to
data/unit_tests.jsonnot being output.Once the above was fixed, several hard-dels relating to bees, the slime market pad, hive exit, and plasma extraction hub surfaced, which were also fixed.
There were additionally some qdel-before-initialization issues which surfaced, too. These issues arose when two fluid-duct-like objects, or two power-cable-like objects, were atop the same tile. Upon loading the map, one would attempt to deconstruct the others so that it could anchor itself - leading to a qdel-before-initialization.
Please testmerge this for a few rounds before merging, to ensure that I didn't break anything.