feat: maintain more info on minimal Java versions #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
added
Type: Enhancement
src/main/java/org/terasology/launcher/repositories/GithubRepositoryAdapter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/terasology/launcher/game/GameVersionNotSupportedException.java
Show resolved
Hide resolved
skaldarnar
force-pushed
the
topic/more-info-on-required-java-version
branch
from
eb6b61e to
227b81a
Compare
BenjaminAmos
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
Add more entries to the
VersionHistoryfor Java 8 and 11 and add a method to determine the required Java version for a game release.If the respective release requires a Java version that is currently not supported, an exception is thrown (and handled). The Github and Jenkins repository adapters may use this to filter out unsupported game releases.
Replaces #707.
How to test
I think the launcher should behave the same as before.
Maybe the very old game releases are filtered out, but I think they are already not part of the list because their tags are no valid semver.
Outstanding before merging
Nothing.