[sapphire] Check and close connection in one place

MozillaSecurity · Mar 30, 2023 · cf8f035 · cf8f035
1 parent 8ff7755
commit cf8f035
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/sapphire/worker.py b/sapphire/worker.py
@@ -278,14 +278,12 @@ def launch(cls, listen_sock, job):
             pass
         except OSError as exc:
             LOG.debug("worker thread not launched: %s", exc)
-            if conn is not None:  # pragma: no cover
-                conn.close()
         except ThreadError:
-            if conn is not None:  # pragma: no cover
-                conn.close()
             # reset accepting status
             job.accepting.set()
             LOG.warning("ThreadError (worker), threads: %d", active_count())
             # wait for system resources to free up
             sleep(0.1)
+        if conn is not None:
+            conn.close()
         return None