feat: introduce LogQueue abstraction to simplify the race condition #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As titled.
Besides, this PR also tried use
read_atandwrite_atto avoid locking a fd. But currentlytokiodoesn't supportread_atorwrite_atfor now. So, it's needed to usetokio::task::spawn_blockingwithstd::fs::Fileand communicate withtokio::sync::oneshot. But after benching the approach, it's found that the jitter of the latency is extremely high. So I abandon the implementation. You can found them in the commit logs if you are interested.Which issues is this PR related to?
#160