Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CE): signup on docker-compose setup fails #400

Closed
wants to merge 2 commits into from

Conversation

xyfer17
Copy link
Contributor

@xyfer17 xyfer17 commented Oct 4, 2024

Description

  • Fixed 404 error during signup in Docker Compose setup.
  • Added env_file: .env to multiwoven-ui service.
  • Updated VITE_API_HOST in ui/Dockerfile.dev for local development.
new_code.mov

Related Issue

Relates to issue #218 - 'Signup on docker-compose setup fails with 404 '.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New Connector (Destination or Source Connector)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would impact existing functionality)
  • Styling change
  • Documentation update
  • Refactoring
  • Chore

How Has This Been Tested?

  1. Run docker-compose up with the updated docker-compose.yml.
  2. Verify that the signup process works without any 404 errors.
  3. Confirm that VITE_API_HOST is set to http://localhost:3000 in local development.

Checklist:

  • Ensure a branch name is prefixed with feature, bugfix, hotfix, release, style or chore followed by / and branch name e.g feature/add-salesforce-connector
  • Added unit tests for the changes made (if required)
  • Have you made sure the commit messages meets the guidelines?
  • Added relevant screenshots for the changes
  • Have you tested the changes on local/staging?
  • Added the new connector in rollout.rb
  • Have you updated the version number of the gem?
  • Have you ensured that your changes for new connector are documented in the docs repo or relevant documentation files?
  • Have you updated the run time dependency in multiwoven-integrations.gemspec if new gems are added
  • Have you made sure the code you have written follows the best practises to the best of your knowledge?

@sumitd94
Copy link
Contributor

sumitd94 commented Oct 17, 2024

@xyfer17 closing this PR as its fixed internally - #409

Thanks for putting in efforts here, appreciate it :)

@sumitd94 sumitd94 closed this Oct 17, 2024
@xyfer17 xyfer17 deleted the fix/docker-deployment branch October 22, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants