Return better NWC error code for payment failures

MutinyWallet · May 8, 2024 · 76ae9cc · 76ae9cc
1 parent cb64198
commit 76ae9cc
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/mutiny-core/src/nostr/nwc.rs b/mutiny-core/src/nostr/nwc.rs
@@ -999,6 +999,8 @@ impl NostrWalletConnect {
                                             nostr_manager.logger,
                                             "Payment timeout, not removing payment from budget"
                                         );
+
+                                        nostr_manager.save_nwc_profile(self.clone())?;
                                     }
                                     MutinyError::NonUniquePaymentHash => {
                                         log_warn!(
@@ -1038,10 +1040,18 @@ impl NostrWalletConnect {
                                     }
                                 }
 
+                                let code = match e {
+                                    MutinyError::InsufficientBalance => {
+                                        ErrorCode::InsufficientBalance
+                                    }
+                                    MutinyError::PaymentTimeout => return Ok(None), // don't send error message for timeout, it can still complete
+                                    _ => ErrorCode::PaymentFailed,
+                                };
+
                                 Response {
                                     result_type: Method::PayInvoice,
                                     error: Some(NIP47Error {
-                                        code: ErrorCode::InsufficientBalance,
+                                        code,
                                         message: format!("Failed to pay invoice: {e}"),
                                     }),
                                     result: None,