Disable mutiny plus profiles instead of delete #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
reviewed
May 8, 2024
Comment on lines
-2155
to
2162
| Some(profile) => { | ||
| if profile.tag != NwcProfileTag::Subscription { | ||
| let mut nwc = profile.clone(); | ||
| nwc.tag = NwcProfileTag::Subscription; | ||
| self.nostr.edit_nwc_profile(nwc)?; | ||
| } | ||
| if let Some(nwc) = nwc { | ||
| // only should have to submit the NWC if never created locally before | ||
| subscription_client.submit_nwc(nwc).await?; | ||
| } | ||
| } |
There was a problem hiding this comment.
Because it's not needed. Why keep it?
There was a problem hiding this comment.
We use this in the front end to mark it as a subscription so we know to not display the nwc connection string
There was a problem hiding this comment.
It should already be marked correctly and that's not how the frontend handles it. https://github.com/MutinyWallet/mutiny-web/blob/a4981cb8cf0d8afe6f7e5d540fac0cc6b9c858d4/src/routes/settings/Connections.tsx#L110-L118
There was a problem hiding this comment.
ah, its for the open in client buttons
There was a problem hiding this comment.
It should already be marked correctly
ah okay, this was for fixing old profiles, that's fine then
TonyGiorgio
force-pushed
the
disable-mutiny-plus
branch
2 times, most recently
from
98f4e2e to
7a9645f
Compare
benthecarman
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially solves this problem: MutinyWallet/mutiny-web#1130
It at least lets you "disable" mutiny+ subscriptions. Nothing yet to make it enable though, but it at least doesn't charge people money that explicitly removed the old profile.
Basically we need to disable, not full remove, because we ensure that a profile exists for subscribers.