[CLI] Deprecation warnings for dependency verification (DVX-698) #20977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
…ication-deprecation
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
changed the title
…ication-deprecation
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
changed the title
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
requested review from
amnn,
tzakian,
stefan-mysten and
jordanjennings-mysten
There was a problem hiding this comment.
Love the comprehensive tests. Thanks @mdgeorge4153!
In a follow up PR we should probably address these flags also for sui client ptb. Unfortunately, if one creates a PTB for publish/upgrade, we cannot pass there the skip-deps-verification.
We might want to add those, not 100% sure though.
cc @tzakian
|
A small nit: I would say we should aim at having a concrete target release when this gets deprecated and put it both in the message and in the release notes. |
stefan-mysten
approved these changes
Feb 3, 2025
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
7 tasks
crates/sui/tests/shell_tests/with_network/source_verification_deprecation/skip_dep_verif.sh
Outdated
Show resolved
Hide resolved
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
added a commit
that referenced
this pull request
Feb 6, 2025
) ## Description This adds a warning that source verification will become opt-in instead of opt-out in a future release, along with the `--verify-deps` flag that currently disables the warning. ## Test plan Several shell tests that cover the behavior with no flags, with both flags, and with each flag independently, on a package with source that has changed since publication. See the snapshot files for the tests and expected output. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [X] CLI: publication and upgrade will now warn that source verification will become opt-in in a future release; the warning can be disabled with either `--skip-dependency-verification` or the new `--verify-deps` flags - [ ] Rust SDK:
stefan-mysten
pushed a commit
that referenced
this pull request
Feb 7, 2025
) ## Description This adds a warning that source verification will become opt-in instead of opt-out in a future release, along with the `--verify-deps` flag that currently disables the warning. ## Test plan Several shell tests that cover the behavior with no flags, with both flags, and with each flag independently, on a package with source that has changed since publication. See the snapshot files for the tests and expected output. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [X] CLI: publication and upgrade will now warn that source verification will become opt-in in a future release; the warning can be disabled with either `--skip-dependency-verification` or the new `--verify-deps` flags - [ ] Rust SDK:
mdgeorge4153
added a commit
that referenced
this pull request
Feb 7, 2025
…cation (#21127) ## Description This adds a warning that source verification will become opt-in instead of opt-out in a future release, along with the `--verify-deps` flag that currently disables the warning. ## Test plan Several shell tests that cover the behavior with no flags, with both flags, and with each flag independently, on a package with source that has changed since publication. See the snapshot files for the tests and expected output. ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [X] CLI: publication and upgrade will now warn that source verification will become opt-in in a future release; the warning can be disabled with either `--skip-dependency-verification` or the new `--verify-deps` flags - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a warning that source verification will become opt-in instead of opt-out in a future release, along with the
--verify-depsflag that currently disables the warning.Test plan
Several shell tests that cover the behavior with no flags, with both flags, and with each flag independently, on a package with source that has changed since publication. See the snapshot files for the tests and expected output.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
--skip-dependency-verificationor the new--verify-depsflags