rpc-alt: getObject, multiGetObjects #21041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
emmazzz
approved these changes
Feb 3, 2025
| .iter() | ||
| .map(|id| response::live_object(ctx, *id, &options)); | ||
|
|
||
| Ok(future::join_all(obj_futures) |
There was a problem hiding this comment.
Is my understanding correct that by doing future::join_all here, we'll be able to group all the load_ones in response::live_object and take advantage of the data loader?
amnn
force-pushed
the
amnn/rpc-get-obj
branch
from
ef2b292 to
502bfea
Compare
amnn
requested review from
a team,
stefan-mysten,
suiwombat,
ronny-mysten and
mystenmark
as code owners
7 tasks
## Description Pull out the data loading part of `fetch_latest_for_system_state` to be used in other scenarios. The shared part performs one data loader look-up to get the latest version of an object, and then another to get the contents at that version. The other option was to implement this as its own data loader, but I opted against that because while that would have shared implementation logic, requests for latest versions and contents from this new data loader would not have been batched with requests from the existing data loaders. ## Test plan CI
## Description Implementing fetching the latest version of an object. This is a pre-cursor to implementing `multiGetObjects`, to make it easier to test the underlying data loader. ## Test plan New E2E test: ``` sui$ cargo nextest run -p sui-indexer-alt-e2e-tests \ -- objects/get_object ```
## Description Implementing multi-gets from the live object set. ## Test plan New E2E tests: ``` sui$ cargo nextest run -p sui-indexer-alt-e2e-tests \ -- objects/multi_get_objects ```
amnn
force-pushed
the
amnn/rpc-get-obj
branch
from
502bfea to
dae3d0d
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement unfiltered live object set look-ups. They are built on top of an
obj_infodata loader which detects whether the object exists in the live object set at that version.This PR also pulls out the common loading logic from
fetch_latest_for_system_stateto be used for generally loading latest content by object ID.Test plan
New E2E tests:
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.