-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[move][move-vm][rewrite][cleanup 0/n] Add JIT Optimization AST, plus preliminary optimizations #21049
base: tzakian/rootless-linkage
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM although a couple nits.
Also if you want to make the changes we discussed in the meeting to the constant inlining feel free to re-ping and I can take a look at that in this PR, or if you want to put that up separately that's fine too.
external-crates/move/crates/move-vm-runtime/src/execution/tracing/tracer.rs
Outdated
Show resolved
Hide resolved
...rnal-crates/move/crates/move-vm-runtime/src/jit/optimization/optimizations/dead_code_elim.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-vm-runtime/src/jit/optimization/translate.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-vm-runtime/src/jit/optimization/translate.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-vm-runtime/src/unit_tests/basic_block_tests.rs
Show resolved
Hide resolved
6af05ef
to
85c3658
Compare
) This sets limits for arenas and the string interner, producing errors if allocation fails. All tests still pass --- Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
85c3658
to
eb6f3e0
Compare
Description
Add optimization AST
Test plan
Tests still pass
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.