Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move][move-vm][rewrite][cleanup 0/n] Add JIT Optimization AST, plus preliminary optimizations #21049

Open
wants to merge 2 commits into
base: tzakian/rootless-linkage
Choose a base branch
from

Conversation

cgswords
Copy link
Contributor

Description

Add optimization AST

Test plan

Tests still pass


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@cgswords cgswords requested a review from tzakian January 31, 2025 23:59
Copy link

vercel bot commented Feb 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 4:06am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 4:06am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 4:06am

@cgswords cgswords temporarily deployed to sui-typescript-aws-kms-test-env February 1, 2025 00:00 — with GitHub Actions Inactive
Copy link
Contributor

@tzakian tzakian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM although a couple nits.

Also if you want to make the changes we discussed in the meeting to the constant inlining feel free to re-ping and I can take a look at that in this PR, or if you want to put that up separately that's fine too.

@cgswords cgswords force-pushed the cgsworsd/vm_rewrite_jit_opt branch from 6af05ef to 85c3658 Compare February 5, 2025 04:03
@cgswords cgswords temporarily deployed to sui-typescript-aws-kms-test-env February 5, 2025 04:03 — with GitHub Actions Inactive
)

This sets limits for arenas and the string interner, producing errors if allocation fails.

All tests still pass

---

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol:
- [ ] Nodes (Validators and Full nodes):
- [ ] gRPC:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [ ] CLI:
- [ ] Rust SDK:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants