[4/n][vm-rewrite][Move] Add shared "old vm types" to move-execution, and update execution versions to use it #21068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-3
branch
from
a1a87a0 to
bba3dc9
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-4
branch
from
f255e3f to
486cb40
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
…and update execution versions to use it This gets the different execution versions working. It does this by replicating old code and traits that are removed in the new VM into the `move-execution/shared` location, and different move-execution and sui-execution versioned code can access these things from there. **NOTE:** This will be moved to a crate outside of `move-execution` in a future PR. Changing the location of the new `shared` dir here will be harder to do rather than making this change higher up. NB: The code in the PR may not be working as future PRs will build on top of this.
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-3
branch
from
bba3dc9 to
e390092
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-4
branch
from
486cb40 to
4dc2972
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
cgswords
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets the different execution versions working. It does this by replicating old code and traits that are removed in the new VM into the
move-execution/sharedlocation, and different move-execution and sui-execution versioned code can access these things from there.NOTE
This will be moved to a crate outside of
move-executionin a future PR after a discussion at the Move team meeting. Changing the location of the newshareddir here will be harder to do rather than making this change higher up.NB: The code in the PR may not be working as future PRs will build on top of this.