[7/n][vm-rewrite][sui-execution] Update adapter #21071
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-6
branch
from
489397b to
53ce0a8
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-7
branch
from
4dde691 to
3c7de3c
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-6
branch
from
53ce0a8 to
04ed3db
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-7
branch
from
3c7de3c to
eee4b44
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-6
branch
from
04ed3db to
89b34cf
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-7
branch
from
eee4b44 to
6942570
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-6
branch
from
89b34cf to
208bdfc
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-7
branch
from
6942570 to
4bd62dc
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
This is the big one... There is still some refactoring and changes need, but broad-strokes this plumbs in the new VM to the adapter. The main conceptual change is the idea of a `LinkedContext` which is an execution context with a specific linkage and VM instance associated with it. All commands currently require a `LinkedContext`. On the TODO list is: 1. To relax the need for a `LinkedContext` for `Upgrade` and `Publish` commands to require a context a priori (however there are some mechanics that will need to be sorted out to make this work). 2. Properly handle type versioning/defining IDs for typetags/type resolution. 3. General cleanup. NB: The code in the PR may not be working as future PRs will build on top of this.
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-6
branch
from
208bdfc to
3f44124
Compare
tzakian
force-pushed
the
tzakian/vm-rewrite-adapter-7
branch
from
4bd62dc to
c6641eb
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tnowacki
reviewed
Feb 7, 2025
| /// Newly published packages | ||
| new_packages: Vec<MovePackage>, | ||
| pub new_packages: Vec<MovePackage>, |
There was a problem hiding this comment.
Please no pub here. Bad things can happen if this is pub--very delicate code
Comment on lines
+128
to
+129
| /// A "reverse" linkage of storage_id -> runtime_id | ||
| pub reverse_linkage: BTreeMap<ObjectID, ObjectID>, |
There was a problem hiding this comment.
Why isn't this a part of ResolvedLinkage?
There was a problem hiding this comment.
No particular reason, I think adding in to that would make sense to me.
| )?; | ||
| let reverse_linkage = linkage | ||
| .iter() | ||
| .map(|(k, v)| (*v, *k)) |
There was a problem hiding this comment.
Is this guaranteed to be bidirectional?
There was a problem hiding this comment.
Yes, we are guaranteed that every version of a package corresponds to exactly one original package id (i.e., package UUID).
Basically, if there were a conflict here it would mean that package A@v1 is somehow both a A@v1 and a B@v_something package which is impossible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the big one...
There is still some refactoring and changes need, but broad-strokes this plumbs in the new VM to the adapter.
The main conceptual change is the idea of a
LinkedContextwhich is an execution context with a specific linkage and VM instance associated with it. All commands currently require aLinkedContext.On the TODO list (but for other PRs) is:
LinkedContextforUpgradeandPublishcommands to require a context a priori (however there are some mechanics that will need to be sorted out to make this work).