Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team 02 - Pull Request - PM1 #1

Open
wants to merge 73 commits into
base: master
Choose a base branch
from

Conversation

RyanHotton
Copy link

PM2 Part 3 - Step 1

smokhov and others added 30 commits January 28, 2016 13:02
Implemented initial setup for the XML parsing.

Approved-by: Miqdad Amirali <[email protected]>
Approved-by: Ryan Hotton <[email protected]>
updated the set up to include the interface and sub classes

Approved-by: Ryan Hotton <[email protected]>
Approved-by: Sophia Kavousifard <[email protected]>
Added  XPath parsing and made a class for it so it can be called anywhere.

Approved-by: Alex Genio <[email protected]>
Approved-by: George Grafos <[email protected]>
Implemented the SAX parser class to be used with or without a search term. Tested it using the RSS parser.

Approved-by: Ryan Hotton <[email protected]>
Approved-by: George Grafos <[email protected]>
AlexGenio and others added 25 commits February 21, 2018 22:42
…ing the pathToStreamAlert variable and fixed a refactoring error.
…for sending parsed xml to slack via streamalert service.
update read me with soph's changes

Approved-by: Alex Genio <[email protected]>
Approved-by: Ryan Hotton <[email protected]>
…738222 (pull request #15)

README.md edited online with Bitbucket
…162080 (pull request #16)

README.md edited online with Bitbucket
PM1 Part 3 -> PM1 branch

Approved-by: Miqdad Amirali <[email protected]>
…t using a search term when testing Part 3.
@smokhov
Copy link
Member

smokhov commented Mar 24, 2018

  • within this PR there is too much unneeded history stuff -- like project templates, PM1.1 and PM1.2; this can be fixed either via git rebase -i in your fork and pick only PM2.3-related commits; then followed by git push --force to rewrite the history, and this will automatically update your PR here; OR, I merge that into a branch; do the same here to clean it all up, but your fork would still have old cruft unless you force-rebase it from here

@@ -1,3 +1,84 @@
<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • conflicts should be resolved before pushing

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be fixed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smokhov just to clarify, you want us to now update the pull request with PM2.3 content instead of just PM1 content?

Thank you for your time.

* LiveTest.java
*
* This file was auto-generated from WSDL
* by the Apache Axis 1.4 Apr 22, 2006 (06:55:48 PDT) WSDL2Java emitter.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • is is valid?

Skellyboy38 pushed a commit to Skellyboy38/streamalert-ws that referenced this pull request Mar 26, 2018
Create parser

Approved-by: Darrel-Day Guerrero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants