Fix prop type for Map and Scrollytelling #1361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: #1324
Description of Changes
While contemplating on what @sandrahoang686 mentioned about the data proptype, I realized that our types are wrong for Map and Scrollytelling (And We have different types, but named same of
DatasetData
which we should address soon.)Notes & Questions About Changes
Map and Scrollytellinglblock seems to expect the same shape of the dataset which is an object (
VedaData<DatasetData>
- am I missing anything?