Osiris Rex Query Builder Initial Addition #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 8, 2025 13:46
…te" so it can be accessed by inheritors
…uilder.within_bbox()
This package contains an specialized query builder implementation that supports within_range and within_bbox calls for use with Osiris Rex products.
|
nutjob4life
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Visual inspection: ✓
Testing with tox: ✓
Approved!
Log:
collected 23 items
tests/pds/peppi/test_orex_products.py ... [ 13%]
tests/pds/peppi/test_products.py .................... [100%]
---------- coverage: platform darwin, python 3.9.20-final-0 ----------
Name Stmts Miss Cover
----------------------------------------------------------------------------------------
.tox/py39/lib/python3.9/site-packages/pds/peppi/client.py 10 0 100%
.tox/py39/lib/python3.9/site-packages/pds/peppi/orex/products.py 5 0 100%
.tox/py39/lib/python3.9/site-packages/pds/peppi/orex/result_set.py 18 0 100%
.tox/py39/lib/python3.9/site-packages/pds/peppi/products.py 5 0 100%
.tox/py39/lib/python3.9/site-packages/pds/peppi/query_builder.py 81 3 96%
.tox/py39/lib/python3.9/site-packages/pds/peppi/result_set.py 74 2 97%
----------------------------------------------------------------------------------------
TOTAL 193 5 97%
============================================ 23 passed in 118.35s (0:01:58) ============================================
.pkg: _exit> python /Users/kelly/Documents/Clients/JPL/PDS/Development/nasa-pds/peppi/.venv/lib/python3.9/site-packages/pyproject_api/_backend.py True setuptools.build_meta
py39: OK (134.81=setup[15.91]+cmd[118.90] seconds)
congratulations :) (134.92 seconds)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
This branch provides a proof-of-concept for a specialized QueryBuilder/ResultSet class tailored for use with Osiris Rex data. A new
orexpackage has been added with inheritors to the base QueryBuilder/ResultSet classes, and implements the specialized query functionswithin_rangeandwithin_bbox.This branch also adds string representation functions to the QueryBuilder and ResultSet classes that allow a user to see a representation of the query string within the object.
⚙️ Test Data and/or Report
Unit tests have been added for the new query functions within the
orexpackage.♻️ Related Issues
Resolves #71