Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some titles and get the full sea ice diagnostics working again #162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dabail10
Copy link
Collaborator

Description of changes:

@TeaganKing
Copy link
Collaborator

Hi @dabail10 is this ready for review?

@dabail10
Copy link
Collaborator Author

This should be ready for review. I realize the coupled_model/config.yml file is still using the "old" variables. Perhaps I should update this.

Copy link
Collaborator

@mnlevy1981 mnlevy1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to modify lines 150 and 160 in the config.yml file -- 150 still uses seaice as the name of the notebook in the compute_notebooks.ice section, and 160 uses nyears instead of climo_nyears when setting parameters for the notebook. (I haven't tried running this yet, but just from looking would expect these to fail.)

@mnlevy1981
Copy link
Collaborator

also, the visual_compare_full notebook is run by both key_metrics and coupled_model examples, right? Do the changes to the ipynb require updates to the key metrics config file?

@dabail10
Copy link
Collaborator Author

Whoops. I had tested with a custom version of config.yml (config_seaice.yml). The compare_obs_lens is run in the key_metrics, while the full is only run in the coupled_model area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants