Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and updates to NCI dask examples #1

Merged
merged 33 commits into from
Jan 19, 2021

Conversation

hot007
Copy link
Contributor

@hot007 hot007 commented Jan 8, 2021

I have reviewed the dask training materials.

  • Many edits are minor language corrections, but some issues are noted in commit comments, mostly around data availability.
  • I'd recommend including as many input datasets as possible in the repo so that it can be run independently of being a member of specific NCI projects. If this is done, it'll be important to include licensing information for each dataset stored in demo_data.
  • It would also be good to rerun some of the notebooks to clear spammy output where clients have been restarted, e.g., and in some cases python warnings should be addressed.
  • Where plots are made, inclusion of coastlines would help readability, and it's important to ensure maps are correctly oriented.
  • Added a license file, the licence must be CC-BY-SA as it is inherited from the dask materials.
  • I'm hoping many of the outputs creating extraneous .png, .html etc files are dynamically produced and removing/ignoring them should just keep the repo clean without affecting outputs for anyone running the code.

I was not able to test all notebooks, only those which did not rely on data other than CMIP in fs38/oi10.

Please consider and accept/reject these suggestions via git so that my contribution is recorded if possible.

Thank you, useful materials!

Claire

hot007 and others added 30 commits January 5, 2021 16:19
…ber of the relevant NCI project. Please make this data publicly available with citation if data licence permits, and/or make data globally readable at NCI. Fixed typo in filename.
…ion with python library name. Use 'with' when opening files in example.
…riable name dd to ddf to avoid library name conflict.
… the repo in a demo_data folder.

2. use np.flipud to correct the orientation of the plots - IMPORTANT.
Minor edits.
… 3 ensemble members? 3. Add coastlines to maps for clarity.
…te first plot to have lon on the horizontal axis; flip second plot to have North at the top.
…nd note membership of project 'fx3' is required for this exercise.
@hot007
Copy link
Contributor Author

hot007 commented Jan 13, 2021

One more update to dask_02, forgot to change dataset name.

@jbw900 jbw900 merged commit d0a030c into NCI-data-analysis-platform:main Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants