Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Show affected proposals in a popup when changing voting duration #145

Closed
4 tasks done
petersalomonsen opened this issue Nov 27, 2024 · 0 comments · Fixed by #148
Closed
4 tasks done

[Task] Show affected proposals in a popup when changing voting duration #145

petersalomonsen opened this issue Nov 27, 2024 · 0 comments · Fixed by #148
Assignees
@petersalomonsen
Labels
Has UX Dependency A development task that has a UX/design dependency.

Comments

@petersalomonsen
Copy link
Collaborator

petersalomonsen commented Nov 27, 2024 •
edited
Loading

Background

Right now the proposals affected by changing voting duration, are displayed in a table below the input field as you type. To reduce disturbance in the user experience, there should rather be a popup showing this information when you click the submit button.

User Story

As an admin
I want a popup when clicking the submit button after changing voting duration
So that I can see which proposals that will expire, or which will have their expiry date prolonged

as described in #119

Acceptance Criteria

  • The current list of affected proposals, that is updated as you type, should be removed
  • A popup like in the screenshot below should be shown when clicking the submit button ( and only if there are proposals that will be affected by the voting duration change )
  • Expired proposals that become active when extending duration days, should also be visible
  • Show pending proposals that will follow the new voting duration ( without expiring or becoming active )

Resources & Additional Notes
@petersalomonsen petersalomonsen added the Has UX Dependency A development task that has a UX/design dependency. label Nov 27, 2024
@petersalomonsen petersalomonsen self-assigned this Nov 27, 2024
@petersalomonsen petersalomonsen mentioned this issue Dec 1, 2024
Merged
@petersalomonsen petersalomonsen moved this from 🆕 Triage to 🏗 In progress in 🚀 DevHub Products Dec 1, 2024
@petersalomonsen petersalomonsen moved this from 🏗 In progress to 👀 In review in 🚀 DevHub Products Dec 10, 2024
ori-near pushed a commit that referenced this issue Dec 11, 2024
@petersalomonsen
show modal with impacted proposals when changing voting duration (#148)
6872aee 
- Removes the current list of affected proposals, that is updated as you
type
- Adds a when clicking the "Submit request" button ( and only if there
are proposals that will be affected by the voting duration change )
- Shows expired proposals that become active when extending duration
days
- Shows pending proposals that will follow the new voting duration (
without expiring or becoming active )


https://github.com/user-attachments/assets/f858e549-b293-4122-9baf-ca3157c32dd3

resolves #145
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in 🚀 DevHub Products Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petersalomonsen petersalomonsen

Labels
Has UX Dependency A development task that has a UX/design dependency.
Projects
🚀 DevHub Products
Status: ✅ Done
Milestone
No milestone
1 participant
@petersalomonsen