show modal with impacted proposals when changing voting duration

[petersalomonsen]

• Removes the current list of affected proposals, that is updated as you type
• Adds a when clicking the "Submit request" button ( and only if there are proposals that will be affected by the voting duration change )
• Shows expired proposals that become active when extending duration days
• Shows pending proposals that will follow the new voting duration ( without expiring or becoming active )

voting--duration-popup-with-changes.mp4

resolves #145

[petersalomonsen]

@ori-near @FREZZZBE See the video above. Regarding the list of impacted proposals. Do you think it should show all pending proposals, or just the ones that will move from pending->expired or expired->pending? Right now it only shows those that will change expired/pending state, while there is still a count ( in the first bullet ) of how many proposals that will follow the new policy without changing state.

[petersalomonsen]

@race-of-sloths include

[race-of-sloths]

@petersalomonsen Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Do you want to apply for monthly streak? Get 8+ score for a single PR this month and receive boost for race-of-sloths!

Current status: executed

Reviewer	Score
@Megha-Dev-19	5

Your contribution is much appreciated with a final score of 5!
You have received 69 (50 base + 15 weekly bonus + 5% lifetime bonus) Sloth points for this contribution

@Megha-Dev-19 received 25 Sloth Points for reviewing and scoring this pull request.

Another weekly streak completed, well done @petersalomonsen! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

• Tag @race-of-sloths inside your pull requests
• Wait for the maintainer to review and score your pull request
• Check out your position in the Leaderboard
• Keep weekly and monthly streaks to reach higher positions
• Boast your contributions with a dynamic picture of your Profile

For maintainers:

• Score pull requests that participate in the Race of Sloths and receive a reward
• Engage contributors with fair scoring and fast responses so they keep their streaks
• Promote the Race to the point where the Race starts promoting you
• Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands

• For contributors
  • Include a PR: @race-of-sloths include to enter the Race with your PR
• For maintainers:
  • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
  • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
  • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
  • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

[Megha-Dev-19]

LGTM

[Megha-Dev-19]

just FYI, we also have this library

[Megha-Dev-19]

@race-of-sloths score 5

[ori-near]

@ori-near @FREZZZBE See the video above. Regarding the list of impacted proposals. Do you think it should show all pending proposals, or just the ones that will move from pending->expired or expired->pending? Right now it only shows those that will change expired/pending state, while there is still a count ( in the first bullet ) of how many proposals that will follow the new policy without changing state.

Thank you @petersalomonsen ... we're getting super close, just have a couple of formatting fixes. Can you please bold "Pending Requests" and "Expired Requests" and also remove "Impacted Requests" bullet and create a Summary of Changes header in a separate line under underneath. Also would be great if we can add the warning icon.

See reference:

[petersalomonsen]

@ori-near @FREZZZBE See the video above. Regarding the list of impacted proposals. Do you think it should show all pending proposals, or just the ones that will move from pending->expired or expired->pending? Right now it only shows those that will change expired/pending state, while there is still a count ( in the first bullet ) of how many proposals that will follow the new policy without changing state.

Thank you @petersalomonsen ... we're getting super close, just have a couple of formatting fixes. Can you please bold "Pending Requests" and "Expired Requests" and also remove "Impacted Requests" bullet and create a Summary of Changes header in a separate line under underneath. Also would be great if we can add the warning icon.

See reference:

I've made the adjustments @ori-near @FREZZZBE Now it looks like this:

I also notice that the table has a different look and feel in your reference image. Should I look into that as part of this PR, or should we follow up that separately and create a standard table style across the portal?