-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
settings page for voting duration #121
Conversation
docs on RPC sandbox
…listing proposals
@race-of-sloths include |
@petersalomonsen Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 13! @Megha-Dev-19 received 25 Sloth Points for reviewing and scoring this pull request. Congratulations @petersalomonsen! Your PR was highly scored and you completed another monthly streak! To keep your monthly streak make another pull request next month and get 8+ score for it What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @petersalomonsen, thanks for attaching the test videos, left some comments.
instances/treasury-devdao.near/widget/pages/settings/VotingDurationPage.jsx
Show resolved
Hide resolved
instances/treasury-devdao.near/widget/pages/settings/VotingDurationPage.jsx
Outdated
Show resolved
Hide resolved
@race-of-sloths score 13 |
…sury-dashboard into feat/settings-voting-duration
@Megha-Dev-19 This feature requires that we add the |
@Megha-Dev-19 I added |
votingduration.mp4
Lowering voting duration should warn and show proposals that will expire because of the change
show-changed-expiry-dates-when-lowering-duration.mp4
When a voting duration change proposal is submitted, a toast will show:
showtoast.mp4
The last test here uses a RPC sandbox, interacting with a real instance of the smart contract. Not on the mainnet, but in a near-workspaces-rs sandbox. This new sandbox facilitates real interaction with the smart contracts in tests, without having to do real mainnet transactions. Also there is a "playground" script which you can use to check how a contract works. Currently only the sputnik-dao contract is deployed.
resolves #116
resolves #127