Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings page for voting duration #121

Merged
merged 27 commits into from
Nov 25, 2024
Merged

Conversation

petersalomonsen
Copy link
Collaborator

@petersalomonsen petersalomonsen commented Nov 10, 2024

votingduration.mp4

Lowering voting duration should warn and show proposals that will expire because of the change

show-changed-expiry-dates-when-lowering-duration.mp4

When a voting duration change proposal is submitted, a toast will show:

showtoast.mp4

The last test here uses a RPC sandbox, interacting with a real instance of the smart contract. Not on the mainnet, but in a near-workspaces-rs sandbox. This new sandbox facilitates real interaction with the smart contracts in tests, without having to do real mainnet transactions. Also there is a "playground" script which you can use to check how a contract works. Currently only the sputnik-dao contract is deployed.

resolves #116
resolves #127

@petersalomonsen
Copy link
Collaborator Author

Check out the video that shows which proposals that will expire when lowering the duration days. @ori-near @FREZZZBE

@petersalomonsen
Copy link
Collaborator Author

@race-of-sloths include

@race-of-sloths
Copy link

race-of-sloths commented Nov 17, 2024

@petersalomonsen Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Do you want to apply for monthly streak? Get 8+ score for a single PR this month and receive boost for race-of-sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@Megha-Dev-19 13

Your contribution is much appreciated with a final score of 13!
You have received 158 (130 base + 20 monthly bonus + 5% lifetime bonus) Sloth points for this contribution

@Megha-Dev-19 received 25 Sloth Points for reviewing and scoring this pull request.

Congratulations @petersalomonsen! Your PR was highly scored and you completed another monthly streak! To keep your monthly streak make another pull request next month and get 8+ score for it

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@petersalomonsen petersalomonsen marked this pull request as ready for review November 17, 2024 18:49
Copy link
Collaborator

@Megha-Dev-19 Megha-Dev-19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @petersalomonsen, thanks for attaching the test videos, left some comments.

@Megha-Dev-19
Copy link
Collaborator

@race-of-sloths score 13

@petersalomonsen
Copy link
Collaborator Author

@Megha-Dev-19 This feature requires that we add the policy_update_parameters:AddProposal permission to a role. How/where can we add this permission to a new or existing role?

@petersalomonsen
Copy link
Collaborator Author

@Megha-Dev-19 I added policy_update_parameters:AddProposal to the Manage Members role and also succeeded in testing this new feature manually as you can see here: https://near.social/astraplusplus.ndctools.near/widget/home?tab=proposals&daoId=testing-astradao.sputnik-dao.near&page=dao

@petersalomonsen petersalomonsen merged commit 22161e3 into main Nov 25, 2024
20 checks passed
@petersalomonsen petersalomonsen deleted the feat/settings-voting-duration branch November 25, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants