Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stake delegation refresh on create request #233

Merged
merged 8 commits into from
Jan 24, 2025

Conversation

Megha-Dev-19
Copy link
Collaborator

@Megha-Dev-19 Megha-Dev-19 commented Jan 22, 2025

Resolves #248

  • Added hover to 'Create request' dropdown
  • Fix the refresh issue with create stake request, update tests to use sandboxrpc to create proposals
    video.webm
    video.webm

@Megha-Dev-19
Copy link
Collaborator Author

@race-of-sloths include

@race-of-sloths
Copy link

race-of-sloths commented Jan 23, 2025

@Megha-Dev-19 Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@petersalomonsen 8

Your contribution is much appreciated with a final score of 8!
You have received 92 (80 base + 15% lifetime bonus) Sloth points for this contribution

@petersalomonsen received 25 Sloth Points for reviewing and scoring this pull request.

We would appreciate your feedback or contribution idea that you can submit here

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@Megha-Dev-19 Megha-Dev-19 marked this pull request as ready for review January 24, 2025 19:07
@Megha-Dev-19 Megha-Dev-19 requested review from petersalomonsen and rubycop and removed request for petersalomonsen January 24, 2025 19:07
@petersalomonsen
Copy link
Collaborator

@race-of-sloths score 8

Copy link
Collaborator

@petersalomonsen petersalomonsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see that the sandbox is used even more for the tests. Deserves a high score!

@Megha-Dev-19 Megha-Dev-19 force-pushed the fix-stake-delegation-refresh branch from 9574fde to 01ad0d8 Compare January 24, 2025 20:33
@Megha-Dev-19 Megha-Dev-19 merged commit 31e4303 into staging Jan 24, 2025
18 of 21 checks passed
@Megha-Dev-19 Megha-Dev-19 deleted the fix-stake-delegation-refresh branch January 24, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create stake request doesn't show w/o refresh
3 participants