Sync Staging #236
Merged
Sync Staging #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have setup 4 accounts `widgets.treasury-factory.near` for all widgets `bootstrap.treasury-factory.near` for initial/template (app.jsx) widgets and for testing: `test-widgets.treasury-factory.near` `test-bootstrap.treasury-factory.near` Things to note: 1) The testing accounts folder is symlinked to the prod account, so we only need to make changes in prod account folder 2) The testing instances is linked to testing widgets account (`test-widgets.treasury-factory.near`) while prod instances are linked to prod 3) After merging this PR, we should start raising PR against `staging` branch (I will change the rules of the repo), which will deploy to testing instances, widget and bootstrap account, and once everything is tested we can create PR against `main` which will deploy to all prod accounts 4) The reference widget for the self create flow will be `bootstrap.treasury-factory.near` for prod and `test-bootstrap.treasury-factory.near` for testing.
- fix chart gradient colors for dark theme - fix pagination dropdown <img width="492" alt="Screenshot 2025-01-15 at 10 40 00" src="https://github.com/user-attachments/assets/db9a906d-22ce-4141-b461-ab60cb676a18" /> <img width="1016" alt="Screenshot 2025-01-15 at 09 52 47" src="https://github.com/user-attachments/assets/3a507be2-5ccc-4f5f-8d70-cbf08396be30" />
- I have deleted `css.jsx` files and move the `themeColor` to config, so we can utilise it as a constant and convert to hsl to get hover effect cover, and also use it in theme page - Added hover effects to all buttons https://github.com/user-attachments/assets/eade6cfd-7feb-41db-9b6d-9885508de7bc - Fixed some styling issues
Fix the `instance` and `treasuryDaoID` assignment.
- since existing proposals doesn't have title/summary/notes since they created the request using other UI/CLI, we should show the description (as it is), as that usually explains what the request is - in settings it doesn't show the voting threshold - w/o theme color the buttons look blank white - unnecessary hover on roles (since they don't have any description for it) - fix navbar in different theme - hide spam tokens ( symbol >30 length), in create payment request - Fix css recipient and voters hover of implicit accounts
- rebuilt "add treasury account" step - removed sputnik dao configuration step - resolved summary modal appearence issue - table fixes <img width="599" alt="Screenshot 2025-01-18 at 14 33 44" src="https://github.com/user-attachments/assets/66d03d48-e588-4e5a-8b1f-c238d848d43d" /> <img width="599" alt="Screenshot 2025-01-18 at 14 33 52" src="https://github.com/user-attachments/assets/40266123-511b-4ced-acc4-2d19bfa86667" /> <img width="1215" alt="Screenshot 2025-01-18 at 18 41 15" src="https://github.com/user-attachments/assets/be59f3b0-8cf3-4b4f-a537-b8c7d6dfd650" /> --------- Co-authored-by: Megha <[email protected]>
Fix the `instance` and `treasuryDaoID` assignment.
- since existing proposals doesn't have title/summary/notes since they created the request using other UI/CLI, we should show the description (as it is), as that usually explains what the request is - in settings it doesn't show the voting threshold - w/o theme color the buttons look blank white - unnecessary hover on roles (since they don't have any description for it) - fix navbar in different theme - hide spam tokens ( symbol >30 length), in create payment request - Fix css recipient and voters hover of implicit accounts
- rebuilt "add treasury account" step - removed sputnik dao configuration step - resolved summary modal appearence issue - table fixes <img width="599" alt="Screenshot 2025-01-18 at 14 33 44" src="https://github.com/user-attachments/assets/66d03d48-e588-4e5a-8b1f-c238d848d43d" /> <img width="599" alt="Screenshot 2025-01-18 at 14 33 52" src="https://github.com/user-attachments/assets/40266123-511b-4ced-acc4-2d19bfa86667" /> <img width="1215" alt="Screenshot 2025-01-18 at 18 41 15" src="https://github.com/user-attachments/assets/be59f3b0-8cf3-4b4f-a537-b8c7d6dfd650" /> --------- Co-authored-by: Megha <[email protected]>
Megha-Dev-19
temporarily deployed
to
treasury-testing.near
GitHub Actions
Inactive
Megha-Dev-19
temporarily deployed
to
treasury-testing-infinex.near
GitHub Actions
Inactive
Megha-Dev-19
temporarily deployed
to
test-widgets.treasury-factory.near
GitHub Actions
Inactive
Megha-Dev-19
temporarily deployed
to
test-bootstrap.treasury-factory.near
GitHub Actions
Inactive
Resolves #241 Added endpoints [here](NEAR-DevHub/ref-sdk-api#7)
Megha-Dev-19
temporarily deployed
to
treasury-testing.near
GitHub Actions
Inactive
Megha-Dev-19
temporarily deployed
to
treasury-testing-infinex.near
GitHub Actions
Inactive
Megha-Dev-19
temporarily deployed
to
test-widgets.treasury-factory.near
GitHub Actions
Inactive
Megha-Dev-19
temporarily deployed
to
test-bootstrap.treasury-factory.near
GitHub Actions
Inactive
<img width="1440" alt="Screenshot 2025-01-29 at 13 43 18" src="https://github.com/user-attachments/assets/9e35bcb0-1726-49c3-bea7-6e3ef1735dde" /> <img width="1440" alt="Screenshot 2025-01-29 at 13 54 40" src="https://github.com/user-attachments/assets/76217c74-89d8-49e9-a8b4-fcf28fd51d15" /> <img width="1438" alt="Screenshot 2025-01-29 at 14 23 52" src="https://github.com/user-attachments/assets/7b464ce4-e055-4e10-b7ee-f8c699b9047d" /> <img width="426" alt="Screenshot 2025-01-29 at 17 04 21" src="https://github.com/user-attachments/assets/cc358b9d-f32f-42aa-9695-4426e0fef893" />
rubycop
temporarily deployed
to
treasury-testing.near
GitHub Actions
Inactive
rubycop
temporarily deployed
to
treasury-testing-infinex.near
GitHub Actions
Inactive
rubycop
temporarily deployed
to
test-widgets.treasury-factory.near
GitHub Actions
Inactive
rubycop
temporarily deployed
to
test-bootstrap.treasury-factory.near
GitHub Actions
Inactive
_Resolves #245_
Tguntenaar
temporarily deployed
to
treasury-testing.near
GitHub Actions
Inactive
Tguntenaar
temporarily deployed
to
treasury-testing-infinex.near
GitHub Actions
Inactive
Tguntenaar
temporarily deployed
to
test-widgets.treasury-factory.near
GitHub Actions
Inactive
Tguntenaar
temporarily deployed
to
test-bootstrap.treasury-factory.near
GitHub Actions
Inactive
Resolves #240 Deleting a proposal, throws error since it doesn't exist in contract state anymore, so I have mocked the same behaviour in test to achieve the result. We can later move all tests to use sandboxrpc instead of mocking results.
Megha-Dev-19
temporarily deployed
to
treasury-testing.near
GitHub Actions
Inactive
Megha-Dev-19
temporarily deployed
to
treasury-testing-infinex.near
GitHub Actions
Inactive
Megha-Dev-19
temporarily deployed
to
test-widgets.treasury-factory.near
GitHub Actions
Inactive
Megha-Dev-19
temporarily deployed
to
test-bootstrap.treasury-factory.near
GitHub Actions
Inactive
Megha-Dev-19
deployed
to
treasury-testing-infinex.near
GitHub Actions
Active
Megha-Dev-19
deployed
to
test-widgets.treasury-factory.near
GitHub Actions
Active
Megha-Dev-19
deployed
to
test-bootstrap.treasury-factory.near
GitHub Actions
Active
petersalomonsen
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.