-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: confusing warning for changing voting policy #252
base: staging
Are you sure you want to change the base?
Conversation
@race-of-sloths include |
@Tguntenaar Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: waiting for merge
Your contribution is much appreciated with a final score of 5! @Megha-Dev-19 received 25 Sloth Points for reviewing and scoring this pull request. What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
would be great to see tests included. |
page.getByText( | ||
"Changing this setting will require 2 vote(s) to approve requests. You will no longer be able to approve requests with 1 vote(s)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we run it on 2-3 instances it's possible they have different configuration set, so please check that we mock the policy, so it always remain same for the tests.
@race-of-sloths score 5 |
Resolves #243
Acceptance Criteria