-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump deps including extreme #5
Conversation
I think we need to change the extreme dep constraint in mix.exs to ensure host applications use the fixed version. maybe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dep constraint
shouldn't |
although I do believe bumping kelvin in harness libs and (unharnessed) apps will give us the desired effect |
yes, just running deps.update in the host app needs to be done and will update extreme, I think it's important for the dependency tree to actually try to prevent people from using < 1.0.5. if it's only all ears for arguments against this, but that's my take. |
ah, good point, I was thinking 2.0 is so far away from us (if it comes at all), that we don't need to worry at all but definitely makes sense to not let it be accidental |
fixes issue that occurred in
agora
caused by a bug inextreme
library addressed with this PR