Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a recruitment carbon flux history variable #1153

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

JessicaNeedham
Copy link
Contributor

@JessicaNeedham JessicaNeedham commented Jan 26, 2024

Description:

New recruits are added to vegetation carbon history variables but we don’t count new recruits as part of daily allocation because their fluxes don’t make sense until they have lived a full day. If we want to test that the carbon budget is closed by checking that delta C = (allocation + recruits) - (mortality + turnover) then we need a recruit carbon flux. This is just the total carbon of new recruits that is added every day. I'm actually not sure if this should be a site level variable like the current FATES_RECRUITMENT_PF variable? I think that way it would include recruits that die on their first day. But since those recruits don't make it into the biomass history variables I don't know if we want that...

Collaborators:

Lots of help from @ckoven and @rgknox

Expectation of Answer Changes:

This should be bfb as it only adds a new history variable.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

Tested with E3SM 93ab10c89 and FATES API 29.

Full results with variables included in each term.

Screenshot 2024-01-26 at 11 48 11

User control of fates history diagnostics by dimension, via namelist setting: fates_history_dimlevel. Control is split between high frequency and dynamics frequency variables, where 0 turns off diagnostics, 1 is for site level and 2 is for high-dimensional variables. Used to speed up the model when no higher dimension varaibles are desired
@glemieux
Copy link
Contributor

Regression testing on derecho against fates-sci.1.72.2_api.34.0.0-ctsm5.1.dev173 are complete with all expected tests passing b4b including expected FIELDLIST diffs due to the new history variable. Note that there were some expected failures due to current issues that aren't listed in the "expected failure" list currently:

That said, this is ready to integrate.

@glemieux glemieux merged commit 84f6904 into NGEET:main Mar 16, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants