generated from NHSDigital/nhs-notify-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCM-7283: Use self-container Cognito User Pool as a temporary auth solution #139
Open
chris-elliott-nhsd
wants to merge
18
commits into
main
Choose a base branch
from
feature/user-validation-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-elliott-nhsd
force-pushed
the
feature/user-validation-2
branch
from
October 17, 2024 14:11
15259c0
to
9b70566
Compare
chris-elliott-nhsd
temporarily deployed
to
dev
October 17, 2024 14:47 — with
GitHub Actions
Inactive
chris-elliott-nhsd
had a problem deploying
to
dev
October 17, 2024 14:52 — with
GitHub Actions
Failure
chris-elliott-nhsd
temporarily deployed
to
dev
October 17, 2024 14:52 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
October 17, 2024 15:15 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
October 17, 2024 15:21 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
October 17, 2024 15:21 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
October 17, 2024 15:27 — with
GitHub Actions
Inactive
mark-r-bjss
reviewed
Oct 17, 2024
mark-r-bjss
reviewed
Oct 18, 2024
mark-r-bjss
reviewed
Oct 18, 2024
mark-r-bjss
reviewed
Oct 18, 2024
src/__tests__/components/forms/CreateSmsTemplate/CreateSmsTemplate.test.tsx
Outdated
Show resolved
Hide resolved
mark-r-bjss
reviewed
Oct 18, 2024
mark-r-bjss
reviewed
Oct 18, 2024
mark-r-bjss
reviewed
Oct 18, 2024
src/components/molecules/NHSNotifyAuthenticator/NHSNotifyAuthenticator.tsx
Outdated
Show resolved
Hide resolved
mark-r-bjss
reviewed
Oct 18, 2024
src/components/molecules/NHSNotifyAuthenticator/NHSNotifyAuthenticator.tsx
Show resolved
Hide resolved
chris-elliott-nhsd
temporarily deployed
to
dev
October 18, 2024 11:32 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
October 18, 2024 11:37 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
October 18, 2024 11:37 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
October 18, 2024 11:46 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
October 18, 2024 12:01 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
October 18, 2024 12:07 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
October 18, 2024 12:07 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
October 18, 2024 12:15 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
October 18, 2024 12:42 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
October 18, 2024 12:47 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
October 18, 2024 12:47 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
October 18, 2024 12:53 — with
GitHub Actions
Inactive
mark-r-bjss
previously approved these changes
Oct 18, 2024
bhansell1
reviewed
Oct 21, 2024
bhansell1
reviewed
Oct 21, 2024
bhansell1
reviewed
Oct 21, 2024
bhansell1
reviewed
Oct 21, 2024
bhansell1
reviewed
Oct 21, 2024
src/components/molecules/NHSNotifyAuthenticator/NHSNotifyAuthenticator.tsx
Outdated
Show resolved
Hide resolved
chris-elliott-nhsd
temporarily deployed
to
dev
October 21, 2024 11:51 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
October 21, 2024 11:56 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
October 21, 2024 11:56 — with
GitHub Actions
Inactive
chris-elliott-nhsd
temporarily deployed
to
dev
October 21, 2024 12:05 — with
GitHub Actions
Inactive
bhansell1
approved these changes
Oct 21, 2024
sean-corrigan1
approved these changes
Oct 22, 2024
chris-elliott-nhsd
changed the title
CCM-6606: Use self-container Cognito User Pool as a temporary auth solution
CCM-7283: Use self-container Cognito User Pool as a temporary auth solution
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a PR to use the user pool that is created as part of the Amplify backend for auth. This is a strictly temporary solution as we would like to move in the medium term to using the separate auth microservice, however this cannot be done until we have done some additional work to move away from Amplify data which does not support external auth providers.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.