Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcc compiler error #42

Merged
merged 4 commits into from
May 15, 2024
Merged

Fix gcc compiler error #42

merged 4 commits into from
May 15, 2024

Conversation

RussTreadon-NOAA
Copy link
Contributor

The gcc compiler requires a field width specification when formatting numeric output. Automated gcc testing flagged the line

     write(6,'(a,i,a)')  'Command line input for ',iargc(),' arguments'

in src/EnKF/gfs/src/getsigensmeanp_smooth.fd/getsigensmeanp_smooth_ncep.f90

This PR adds a field width to the integer format so that the above line reads

     write(6,'(a,i3,a)')  'Command line input for ',iargc(),' arguments'

With this change in place automated gcc testing passes.

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this May 15, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

@CoryMartin-NOAA and @DavidNew-NOAA , automated gcc testing flagged the formatting error described above. This PR adds a field width to the i format. This allows the gcc test to pass. I'll merge into develop once it is reviewed and approved.

@RussTreadon-NOAA RussTreadon-NOAA merged commit bb03e17 into develop May 15, 2024
8 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/safeguard branch May 15, 2024 12:37
@RussTreadon-NOAA
Copy link
Contributor Author

Thank you @CoryMartin-NOAA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants