Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for aerosol analysis fields from Gaussian increment #50

Merged
merged 10 commits into from
Aug 12, 2024

Conversation

CoryMartin-NOAA
Copy link
Contributor

JEDI can produce a Gaussian analysis increment, this PR adds the option to create a Gaussian analysis atmanl.nc file with the JEDI-based aerosol increment file in addition to the existing GSI atmospheric analysis increment.

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. We should default do_aero = .false. I assume tests have been run to confirm that the do_aero = .true. case works as expected.

@CoryMartin-NOAA
Copy link
Contributor Author

yes, tests with do_aero=.true. work as expected

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Approve pending confirmation that the do_aero=.true. option works as intended.

@RussTreadon-NOAA
Copy link
Contributor

If @andytangborn is OK with the changes, I can merge this PR into develop.

Copy link

@andytangborn andytangborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@RussTreadon-NOAA RussTreadon-NOAA merged commit 4d4daa2 into develop Aug 12, 2024
8 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/calcanl-aero branch August 12, 2024 15:44
DavidHuber-NOAA added a commit to DavidHuber-NOAA/GSI-utils that referenced this pull request Sep 6, 2024
* origin/develop:
  Move to contrib spack-stack on Jet (NOAA-EMC#52)
  Add handling to calculate analysis and interplate increments for number (NOAA-EMC#46)
  Add support for aerosol analysis fields from Gaussian increment (NOAA-EMC#50)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants