update hera spack-stack path

[RussTreadon-NOAA]

Description
The spack-stack path is changing on Hera. This PR updates the path to the new location.

Resolves #828

Type of change

• Maintenance (non-breaking change to maintain functionality)

How Has This Been Tested?

The changes in this PR only impact Hera. The following has been done on Hera

• Successfully build GSI
• Run ctests with Passed result for all tests

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• New and existing tests pass with my changes

[RussTreadon-NOAA]

Mark this PR as Draft until Hera ctests finish.

[RussTreadon-NOAA]

Install feature/update_heara_path at ec2303d and develop at 27c03e8 on Hera. Run ctests with following results

Test project /scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/update/build
    Start 1: global_4denvar
    Start 2: rtma
    Start 3: rrfs_3denvar_rdasens
    Start 4: hafs_4denvar_glbens
    Start 5: hafs_3denvar_hybens
    Start 6: global_enkf
1/6 Test #3: rrfs_3denvar_rdasens .............   Passed  696.05 sec
2/6 Test #2: rtma .............................   Passed  1040.22 sec
3/6 Test #5: hafs_3denvar_hybens ..............   Passed  1237.82 sec
4/6 Test #6: global_enkf ......................   Passed  1435.32 sec
5/6 Test #4: hafs_4denvar_glbens ..............   Passed  1774.49 sec
6/6 Test #1: global_4denvar ...................   Passed  1976.88 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) = 1977.62 sec

All tests pass.

[RussTreadon-NOAA]

This PR is Ready for review

[RussTreadon-NOAA]

@CoryMartin-NOAA , @ShunLiu-NOAA , and @hu5970 : I can not approve my own PR. This PR only impacts Hera. ctests pass on Hera.

[DavidHuber-NOAA]

@RussTreadon-NOAA @aerorahul The GNU stack does not exist in /contrib for the gsi-addon-dev-rocky8 environment, so this module file does not load correctly. Do we need to continue supporting GNU compilers for the GSI? If so, I will make the request to EPIC to have the GNU stack installed as well.

[RussTreadon-NOAA]

@DavidHuber-NOAA , I am not aware of any requirement to support the gnu compiler on Hera. Let me cross check with the GSI Review Committee.

[aerorahul]

GCC provides broader compatibility across different platforms making the code base easier to port in the long run. It also has a stricter adherence to Fortran standards. This helps keeping the code base up to date with current standards and allows developers to write better code.
Intel supports many deprecated standards in the interest of making the code developer-friendly, but they get exposed when -warn all flag is used (A requirement for operational acceptance of any code).

My 2c, FWIW.

[RussTreadon-NOAA]

@aerorahul , do you recommend that EPIC install a GNU stack on support machines?

[RussTreadon-NOAA]

FYI, GSI-Monitor and GSI-utils contain hera gnu modulefiles. See GSI-Monitor PR #161 and GSI-utils PR #65.

[RussTreadon-NOAA]

Attempts to use gsi_hera.gnu.lua from GSI develop fail. The path to spack-stack is missing -rocky8. Update working copy of develop gsi_hera.gnu.lua with

-prepend_path("MODULEPATH", "/scratch1/NCEPDEV/nems/role.epic/spack-stack/spack-stack-1.6.0/envs/gsi-addon-dev/install/modulefiles/Core")
+prepend_path("MODULEPATH", "/scratch1/NCEPDEV/nems/role.epic/spack-stack/spack-stack-1.6.0/envs/gsi-addon-dev-rocky8/install/modulefiles/Core")

Set COMPILER=gnu in shell. Execute ./build.sh. Build fails with

[  0%] Building Fortran object src/mgbf/CMakeFiles/mgbf.dir/jp_pkind.f90.o
cd /scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/develop/build/src/mgbf && /apps/gnu/gcc-9.2.0/bin/gfortran -DNDEBUG -I/scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/develop/build/src/mgbf/include/mgbf -g -fbacktrace -fconvert=big-endian -O3 -DNDEBUG -O3 -Jinclude/mgbf -c /scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/develop/src/mgbf/jp_pkind.f90 -o CMakeFiles/mgbf.dir/jp_pkind.f90.o
/scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/develop/src/mgbf/jp_pkind.f90:22:4:

   22 | use mpi
      |    1
Fatal Error: Cannot open module file 'mpi.mod' for reading at (1): No such file or directory
compilation terminated.

The Hera gnu build is broken in develop. This will not be resolved by this PR. If we want to maintain the GSI gnu build capability on Hera, a possible path forward is to

1. open an issue documenting the problems with the develop gnu build on Hera
2. merge this PR as is into develop

[DavidHuber-NOAA]

@RussTreadon-NOAA I am good with that solution. I will also reach out to EPIC to request a GNU installation of the gsi-addon environment.

[DavidHuber-NOAA]

Approve pending the creation of a follow-on issue to track GNU build on Hera.

[RussTreadon-NOAA]

GSI issue #831 has been opened to document that the Hera gnu build is broken.