Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JGDAS_ENKF_SFC job with COMIN/COMOUT prefix instead of COM #3291

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

mingshichen-noaa
Copy link
Contributor

Description

NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global JGDAS_ENKF_SFC and JGDAS_ENKF_ARCHIVE jobs.

Refs #2451

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • Clone and build on RDHPCS
  • Cycled tests on Hercules
  • Forecast-only tests on Hercules

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@KateFriedman-NOAA
Copy link
Member

@mingshichen-noaa The prior incarnation of this PR made COM changes for the enkf_sfc and the enkf_update job but this new PR includes COM changes for the enkf_sfc and enkf_archive jobs. Is this intentional to have this change the archive scripts instead of the update scripts? Please confirm, thanks!

@mingshichen-noaa
Copy link
Contributor Author

@KateFriedman-NOAA
This PR (#3291) doesn't include "JGDAS_ENKF_UPDATE" job and associated scripts because previous PR (#3170) CI tests ran into trouble (test status of some tasks failed in Hercules). I am working on a new branch (feature/jgdas_enkf_update_job) in hera environment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants