Automatic Int precision and stencil regeneration change #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld remove the need for i32/i64 declaration (although their functionality is still retained) and replace both with the regular Int type
FlorianDeconinck
requested changes
Feb 3, 2025
ndsl/dsl/typing.py
Outdated
|
|
||
|
|
||
| def global_set_floating_point_precision(): | ||
| def global_set_precision(): | ||
| """Set the global floating point precision for all reference | ||
| to Float in the codebase. Defaults to 64 bit.""" |
| to Float in the codebase. Defaults to 64 bit.""" | ||
| global Float | ||
| precision_in_bit = floating_point_precision() | ||
| def global_set_precision(): |
There was a problem hiding this comment.
- def global_set_precision():
+ def global_set_precision() -> type:| elif precision_in_bit == 32: | ||
| return NDSL_32BIT_FLOAT_TYPE | ||
| return NDSL_32BIT_FLOAT_TYPE, NDSL_32BIT_INT_TYPE | ||
| else: | ||
| NotImplementedError( |
There was a problem hiding this comment.
Suggested change
| NotImplementedError( | |
| raise NotImplementedError( |
|
While you are in the vicinity can you also had specialization type for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a feature to automatically determine the precision of an integer based on the global precision of the stencil. retained functionality of i32/i64, but now raises an error if an integer of the incorrect precision is passed to the stencil. In short:
Int/i32/i64should now behave identically toFloat/f32/f64.Changed the default value of
rebuildfrom True to False for _get_factories. This alleviates a problem of unmodified stencils being recompiled when they are called from a subclass.