Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Adding user guide documentation #97

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

fmalatino
Copy link
Contributor

Description
This PR includes documentation as created by @xyuan. Upon approval a Read The Docs will be created for these documents.

How Has This Been Tested?
Does not affect functional code

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments - this obviously needs much more work so let's just focus on fixing the basics and putting a structure in place

# built documents.
#
# The short X.Y version.
version = u"0.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to current

# The short X.Y version.
version = u"0.1"
# The full version, including alpha/beta/rc tags.
release = u"0.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem above

Gt4py
==========

pace-physics includes the Python implementation of GFS physics built using the GT4Py domain-specific language.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pySHiELD not pace-physics

@@ -0,0 +1,7 @@
Gt4py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


overview
users_guide
program_guide
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The users guide is not a users guide it's a developer guide or a technical guide. Please move the content of it into a "NDSL developer technical documentation" and "Users guide" should be a user forward, no technical detail, but how to code with NDSL.

While you are at it introduce a "porting from Fortran" section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants