Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin numpy~=1.0 #47

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Pin numpy~=1.0 #47

merged 3 commits into from
Jul 11, 2024

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Jul 10, 2024

See #46 for more detail.

fixes #46

@aaraney aaraney requested a review from madMatchstick July 10, 2024 19:38
@aaraney
Copy link
Member Author

aaraney commented Jul 10, 2024

Assume that the macos failures are b.c. an arm runner picked the job up. Curious if conda is necessary to install this now. Moving this to draft to test that theory out.

@aaraney
Copy link
Member Author

aaraney commented Jul 10, 2024

Good thing, is it looks like pinning numpy has fixed the issue.

@aaraney aaraney marked this pull request as draft July 10, 2024 19:44
@aaraney aaraney marked this pull request as ready for review July 10, 2024 19:51
@aaraney
Copy link
Member Author

aaraney commented Jul 10, 2024

Looks like that fixed it.

Copy link
Contributor

@madMatchstick madMatchstick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@madMatchstick madMatchstick merged commit ee33923 into NOAA-OWP:master Jul 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Test Workflow Fails; NumPy v2.0
2 participants