Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major update for modern neuralhydrology configuration and ensemble predictions #56

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

jmframe
Copy link
Contributor

@jmframe jmframe commented Jan 30, 2025

This pull request fixes quite a few problems. Sorry for the major PR, but I'm not always sure how to do these things. The two big reasons for this PR is 1) including trained LSTM weights with AORC forcings that were trained with the new scalar configuration from neuralhydrology, and 2) adding the ability to make ensemble mean predictions from the LSTM BMI.

Additions

Removals

Changes

Testing

  1. Tests were done to ensure the BMI successfully runs and the LSTM produces good predictions with ngen compiled on Pantarhei
  2. Tests were done to ensure the BMI successfully runs and the LSTM produces good predictions with NGIAB
  3. Two demonstration notebooks show the successful module runs with sample data in Jupyter Notebooks: https://github.com/jmframe/lstm/tree/readme_update/notebooks

@JoshCu
Copy link

JoshCu commented Feb 4, 2025

Tested using nextgen in a box with both a single model and ensemble for gage-14216500 --start 1998-11-01 --end 1999-01-01 Inputs generated using this tool / branch
Single model

train_cfg_file:
 - /ngen/ngen/extern/lstm/trained_neuralhydrology_models/nh_AORC_hourly_25yr_1210_112435_7/config.yml

image
Ensemble

train_cfg_file:
  - /ngen/ngen/extern/lstm/trained_neuralhydrology_models/nh_AORC_hourly_25yr_1210_112435_7/config.yml
  - /ngen/ngen/extern/lstm/trained_neuralhydrology_models/nh_AORC_hourly_25yr_1210_112435_8/config.yml
  - /ngen/ngen/extern/lstm/trained_neuralhydrology_models/nh_AORC_hourly_25yr_1210_112435_9/config.yml
  - /ngen/ngen/extern/lstm/trained_neuralhydrology_models/nh_AORC_hourly_25yr_seq999_seed101_0701_143442/config.yml
  - /ngen/ngen/extern/lstm/trained_neuralhydrology_models/nh_AORC_hourly_25yr_seq999_seed103_2701_171540/config.yml
  - /ngen/ngen/extern/lstm/trained_neuralhydrology_models/nh_AORC_hourly_slope_elev_precip_temp_seq999_seed101_2801_191806/config.yml

image

@aaraney aaraney mentioned this pull request Feb 6, 2025
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants