Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] HP-RTU measure - upsizing logic fix #274

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −9
Open

[WIP] HP-RTU measure - upsizing logic fix #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions resources/measures/upgrade_hvac_add_heat_pump_rtu/measure.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ class AddHeatPumpRtu < OpenStudio::Measure::ModelMeasure
# defining global variable
# adding tolerance because EnergyPlus unit conversion differs from manual conversion
# reference: https://github.com/NREL/EnergyPlus/blob/337bfbadf019a80052578d1bad6112dca43036db/src/EnergyPlus/DataHVACGlobals.hh#L362-L368
CFM_PER_TON_MIN_RATED = 300 * (1 + 0.08) # hard limit of 300 and tolerance of 8% (based on EP unit conversion mismatch plus more)
CFM_PER_TON_MAX_RATED = 450 * (1 - 0.08) # hard limit of 450 and tolerance of 8% (based on EP unit conversion mismatch plus more)
CFM_PER_TON_MIN_RATED = 300 #* (1 + 0.08) # hard limit of 300 and tolerance of 8% (based on EP unit conversion mismatch plus more)
CFM_PER_TON_MAX_RATED = 450 #* (1 - 0.08) # hard limit of 450 and tolerance of 8% (based on EP unit conversion mismatch plus more)
# CFM_PER_TON_MIN_OPERATIONAL = 200 # hard limit of 200 for operational minimum threshold for both heating/cooling
# CFM_PER_TON_MAX_OPERATIONAL_HEATING = 600 # hard limit of 600 for operational maximum threshold for both heating
# CFM_PER_TON_MAX_OPERATIONAL_COOLING = 500 # hard limit of 500 for operational maximum threshold for both cooling
Expand Down Expand Up @@ -1395,7 +1395,9 @@ def run(model, runner, user_arguments)
runner.registerInfo('sizing summary: sizing run needed')
return false if std.model_run_sizing_run(model, "#{Dir.pwd}/SR1") == false

model.applySizingValues
if is_sizing_run_needed == true
model.applySizingValues
end
end

# get sql from sizing run
Expand Down Expand Up @@ -2188,8 +2190,8 @@ def run(model, runner, user_arguments)
upsize_factor = (dx_rated_htg_cap_applied - orig_clg_coil_gross_cap) / orig_clg_coil_gross_cap

# upsize airflow accordingly
design_heating_airflow_m_3_per_s *= (1 + upsize_factor)
design_cooling_airflow_m_3_per_s *= (1 + upsize_factor)
# design_heating_airflow_m_3_per_s *= (1 + upsize_factor)
# design_cooling_airflow_m_3_per_s *= (1 + upsize_factor)

if debug_verbose
runner.registerInfo('sizing summary: before rated cfm/ton adjustmant')
Expand Down
8 changes: 4 additions & 4 deletions resources/measures/upgrade_hvac_add_heat_pump_rtu/measure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>add_heat_pump_rtu</name>
<uid>f4567a68-27f2-4a15-ae91-ba0f35cd08c7</uid>
<version_id>4cf5bd5c-a940-4dc5-83d1-e17104a0bf06</version_id>
<version_modified>2024-10-29T14:28:52Z</version_modified>
<version_id>3c0d8886-dd54-4e8f-a624-4469d1f5345a</version_id>
<version_modified>2025-01-17T17:10:37Z</version_modified>
<xml_checksum>5E2576E4</xml_checksum>
<class_name>AddHeatPumpRtu</class_name>
<display_name>add_heat_pump_rtu</display_name>
Expand Down Expand Up @@ -292,7 +292,7 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>4FEEEBF8</checksum>
<checksum>4849417A</checksum>
</file>
<file>
<filename>performance_map_CCHP_spec_2027.json</filename>
Expand Down Expand Up @@ -322,7 +322,7 @@
<filename>measure_test.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>8F68BD89</checksum>
<checksum>1DABE5DA</checksum>
</file>
</files>
</measure>