Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UEB: Grade 1 not required for expression above and below #200

Merged
merged 1 commit into from
Oct 25, 2023
Merged

UEB: Grade 1 not required for expression above and below #200

merged 1 commit into from
Oct 25, 2023

Conversation

rob-aph
Copy link
Contributor

@rob-aph rob-aph commented Oct 25, 2023

I checked carefully, and as closely as I can tell, Grade 1 mode is not required for expression directly above and expression directly below. These changes are passing the braille UEB tests

NSoiffer
NSoiffer approved these changes Oct 25, 2023
View reviewed changes
Copy link
Owner

@NSoiffer NSoiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

I looked at my tests and the only ones that would be affected by the change are examples with a sum and limit from section 7. Both of those are already in G1 mode. Too bad they didn't have an example where this made a difference.

@NSoiffer NSoiffer merged commit 0c603e1 into NSoiffer:main Oct 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NSoiffer NSoiffer NSoiffer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rob-aph @NSoiffer