Interface additions #253
Merged
Interface additions #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a test for it. Also fixed MoveLastCommand for when there isn't a last command. In this case, the stack was being popped which left it empty. I changed 'pop' so it won't pop the last (initial starting node) off the stack.
``` get_navigation_node_from_braille_position(position: usize) -> Result<(String, usize)> ``` Implements #123, but still a little buggy. Fix bug I discovered where in Nemeth, the baseline indicator isn't highlighted when the `msup` node is the nav focus. To do this, I added a hack that hopefully doesn't get out of hand: 'b' is turned into '𝑏' to indicate this is a highlighted 'b' and the substitution has dots 7 & 8 added to it. A couple of regexps needed to change a little to handled this. This only happens if "BrailleCode" is "Nemeth" because 'b' is used for other things in UEB, etc. I added a test that sweeps across all the positions in the quadratic formula. Nemeth passes, but now I need to work on making UEB pass that same test.
Pulled leaf part out find_navigation_node()
… UEB, and CMU. Fixes #125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added interfaces:
pub fn set_navigation_mathml(id: String, offset: usize) -> Result()pub fn get_navigation_node_from_braille_position(position: usize) -> Result<(String, usize)>