Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translatons of units in tranditional chinese #321

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

hjy1210
Copy link
Contributor

@hjy1210 hjy1210 commented Dec 12, 2024

Make translatons of units in tranditional chinese and pass tests in units.rs

@NSoiffer NSoiffer merged commit d3e3aaf into NSoiffer:main Dec 13, 2024
1 check failed
@NSoiffer
Copy link
Owner

Thanks!

@hjy1210
Copy link
Contributor Author

hjy1210 commented Dec 13, 2024

Do you mean check failed is not an issue?

@NSoiffer
Copy link
Owner

The failure is in my code. Unfortunately a change I made maybe two months ago caused a failure in one of the navigation tests. I've been meaning to improve navigation so that if an intent attribute is given, that changes the navigation. That failure was the catalyst to finally make the change. It is a bigger change that I originally thought and I've been busy with some other things so I haven't gotten it all back together. Some of the failures that are listed are already fixed, but I have some more navigation fixes in those files and don't want to commit them until I get through a few more problems that need fixing.

@hjy1210
Copy link
Contributor Author

hjy1210 commented Dec 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants