Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add danger #1

Merged
merged 8 commits into from
Jan 23, 2019
Merged

Add danger #1

merged 8 commits into from
Jan 23, 2019

Conversation

freddy5566
Copy link
Member

@freddy5566 freddy5566 commented Jan 23, 2019 •
edited
Loading

  • setup danger for further usage

reference: https://danger.systems/js/
example file: facebook/react-native facebook/react

@npc-official
Copy link
Member

npc-official commented Jan 23, 2019 •
edited
Loading

Warnings
⚠️ ❗ Big PR - This PR is extremely unlikely to get reviewed because it touches 606 lines.
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
Messages
📖 Changed Files in this PR: - .circleci/config.yml- package.json- yarn.lock

Generated by 🚫 dangerJS against 332faef

@freddy5566 freddy5566 requested a review from yaoandy107 January 23, 2019 06:51
yaoandy107
yaoandy107 approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@yaoandy107 yaoandy107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@yaoandy107 yaoandy107 merged commit f4dbb12 into master Jan 23, 2019
@yaoandy107 yaoandy107 deleted the feature/setup-danger branch January 23, 2019 11:32
@yaoandy107 yaoandy107 restored the feature/setup-danger branch January 23, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaoandy107 yaoandy107 yaoandy107 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freddy5566 @npc-official @yaoandy107