-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstracting create pairing fixture js #139
Open
yvanchu
wants to merge
105
commits into
master
Choose a base branch
from
abstracting-create-pairing-fixtureJS
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k to allowRepeatContributions to incident
…o contributing + finish templates for the mutual friend
|
Secret | Commit | Filename | Detected At | |
---|---|---|---|---|
Generic Private Key | cb8efff | private/ios/pp.pem | 06:05 January 21st, 2022 | View secret |
MongoDB Credentials | a100ac6 | db.py | 21:42 November 8th, 2021 | View secret |
MongoDB Credentials | a100ac6 | db.py | 21:42 November 8th, 2021 | View secret |
MongoDB Credentials | a100ac6 | db.py | 21:42 November 8th, 2021 | View secret |
MongoDB Credentials | a100ac6 | db.py | 21:42 November 8th, 2021 | View secret |
Generic Private Key | cb7c1cf | private/ios/key.pem | 21:42 November 8th, 2021 | View secret |
Generic Private Key | 001c4c2 | private/ios/key.pem | 21:42 November 8th, 2021 | View secret |
Generic Private Key | e659566 | private/ios/AuthKey_W9H43BKTXS.p8 | 22:26 November 8th, 2021 | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.
Our GitHub checks need improvements? Share your feedbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not quite sure where to get the list of pairing usernames, so I just hardcoded that as an array in fixtures.js in line 214