Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstracting create pairing fixture js #139

Open
wants to merge 105 commits into
base: master
Choose a base branch
from

Conversation

yvanchu
Copy link

@yvanchu yvanchu commented Jan 21, 2022

I am not quite sure where to get the list of pairing usernames, so I just hardcoded that as an array in fixtures.js in line 214

mtruong68 and others added 30 commits August 25, 2020 14:25
…o contributing + finish templates for the mutual friend
@gitguardian
Copy link

gitguardian bot commented Jan 21, 2022

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
Secret Commit Filename Detected At
Generic Private Key cb8efff private/ios/pp.pem 06:05 January 21st, 2022 View secret
MongoDB Credentials a100ac6 db.py 21:42 November 8th, 2021 View secret
MongoDB Credentials a100ac6 db.py 21:42 November 8th, 2021 View secret
MongoDB Credentials a100ac6 db.py 21:42 November 8th, 2021 View secret
MongoDB Credentials a100ac6 db.py 21:42 November 8th, 2021 View secret
Generic Private Key cb7c1cf private/ios/key.pem 21:42 November 8th, 2021 View secret
Generic Private Key 001c4c2 private/ios/key.pem 21:42 November 8th, 2021 View secret
Generic Private Key e659566 private/ios/AuthKey_W9H43BKTXS.p8 22:26 November 8th, 2021 View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.

 

Our GitHub checks need improvements? Share your feedbacks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants