Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

購入報告の追加モーダルにバリデーションを付けた(物品名が空白の時のみ) #665

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

hikahana
Copy link
Collaborator

対応Issue

resolve #651

概要

購入報告のところにある報告登録のモーダルから空の購入物品を登録できてしまうのを防ぐため、物品名が空の場合のバリデーションを設けた

画面スクリーンショット等

  • URL
    スクリーンショット
image

テスト項目

  • 購入報告で物品を追加しようとしたときにボタンが押せないようになっているか
  • 物品名を入力したらボタンが押せるようになっているか

備考

やまのPRを参考にしました。

Copy link
Collaborator

@imaimai17468 imaimai17468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kubosaka Kubosaka merged commit ef26497 into develop Dec 12, 2023
3 checks passed
@Kubosaka Kubosaka deleted the feat/hikahana/651-add-validation-purcahse-report branch December 12, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

購入報告の購入物品の追加モーダルにバリデーションをつける
4 participants